Skip to content

feat(user-context): show maintenance message if whoami failed #8640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2023
Merged

feat(user-context): show maintenance message if whoami failed #8640

merged 1 commit into from
Apr 17, 2023

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 13, 2023 •
edited
Loading

Summary

Problem

When we migrate to GCP, the API might be temporarily unavailable for a few minutes, but our users won't notice this unless they execute any actions involving the API.

Solution

Show a maintenance message if the whoami request fails.

Screenshots

Before

image

After

image

How did you test this change?

Blocked the /api/v1/whoami request using DevTools.

@github-actions github-actions bot added the plus work around features related to MDN Plus label Apr 13, 2023
@caugner caugner requested a review from fiji-flo April 13, 2023 20:18
@caugner caugner force-pushed the show-maintenance-info-if-whoami-failed branch 2 times, most recently from 3cc0a48 to f6f73dd Compare April 13, 2023 20:46
@caugner caugner marked this pull request as ready for review April 13, 2023 20:47
@caugner caugner force-pushed the show-maintenance-info-if-whoami-failed branch from f6f73dd to a5325b6 Compare April 13, 2023 20:48
@caugner caugner force-pushed the show-maintenance-info-if-whoami-failed branch from a5325b6 to 4bde96d Compare April 13, 2023 20:53
@caugner caugner added the p1 We will address this soon and will provide capacity from our team for it in the next few releases. label Apr 14, 2023
fiji-flo
fiji-flo approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up

@fiji-flo fiji-flo merged commit 8ab9a0a into main Apr 17, 2023
@fiji-flo fiji-flo deleted the show-maintenance-info-if-whoami-failed branch April 17, 2023 14:27
@caugner caugner mentioned this pull request Mar 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

Assignees
No one assigned
Labels
gcp-migration p1 We will address this soon and will provide capacity from our team for it in the next few releases. plus work around features related to MDN Plus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caugner @fiji-flo